Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy client configs travis way #293

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@zolia
Copy link
Member

commented Jul 12, 2018

No description provided.

@zolia zolia requested review from donce, tadovas and Waldz as code owners Jul 12, 2018

@zolia zolia force-pushed the HOTFIX/verbose-standalone-packaging branch from f19d1a6 to 3ff03f8 Jul 12, 2018

cp -vp ${BINARY} ${DIR_TEMP}/mysterium_client
cp -vrp "bin/common_package/" ${DIR_TEMP}/config

if [[ -d "bin/client_package/config/${OS}/" ]]; then

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 12, 2018

Member

Same code is duplicated in bin/client_build and would be nice to fix both places.
Duplication is also an issue

This comment has been minimized.

Copy link
@zolia

zolia Jul 12, 2018

Author Member

moved to function

@Waldz Waldz changed the base branch from release/0.2 to master Jul 12, 2018

@zolia zolia force-pushed the HOTFIX/verbose-standalone-packaging branch from 52e4872 to 060ce95 Jul 12, 2018

@zolia zolia changed the title verbose copy copy client configs travis way Jul 12, 2018

@zolia zolia force-pushed the HOTFIX/verbose-standalone-packaging branch from 060ce95 to 3806888 Jul 12, 2018

@Waldz

Waldz approved these changes Jul 12, 2018

@Waldz Waldz merged commit 2a685aa into master Jul 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the HOTFIX/verbose-standalone-packaging branch Jul 12, 2018

@Waldz Waldz restored the HOTFIX/verbose-standalone-packaging branch Jul 12, 2018

@zolia zolia deleted the HOTFIX/verbose-standalone-packaging branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.