Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: copy proper config files #296

Merged

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Jul 12, 2018

Picked same fixed for release

zolia and others added some commits Jul 12, 2018

Merge pull request #290 from MysteriumNetwork/HOTFIX/fix-standalone-p…
…ackaging

HOTFIX: copy proper config files
Merge pull request #291 from MysteriumNetwork/HOTFIX/fix-standalone-p…
…ackaging

HOTFIX: copy proper config files
Merge pull request #293 from MysteriumNetwork/HOTFIX/verbose-standalo…
…ne-packaging

copy client configs travis way

@Waldz Waldz requested review from tadovas, donce and zolia Jul 12, 2018

@@ -7,3 +7,12 @@ function get_linker_ldflags {
[ -n "$BUILD_NUMBER" ] && echo -n "-X 'github.com/mysterium/node/metadata.BuildNumber=${BUILD_NUMBER}' "
[ -n "$BUILD_VERSION" ] && echo -n "-X 'github.com/mysterium/node/metadata.Version=${BUILD_VERSION}' "
}

function copy_client_config {

This comment has been minimized.

Copy link
@tadovas

tadovas Jul 13, 2018

Member

Can this function be generlized even more? I.e. copy_config with parameters $OS $DIR_TEMP ?

@tadovas
Copy link
Member

left a comment

LGTM

@zolia

zolia approved these changes Jul 13, 2018

@zolia zolia merged commit 62027fd into mysteriumnetwork:release/0.2 Jul 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Waldz Waldz deleted the Waldz:hotfix/fix-standalone-packaging branch Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.