Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Communication Channel, Glide integration #30

Merged
merged 5 commits into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Sep 5, 2017

No description provided.

@Waldz Waldz requested review from interro, ignasbernotas and cirka and removed request for interro Sep 6, 2017

@Waldz Waldz changed the title SPIKE: Custom Communication Channel Custom Communication Channel, Glide integration Sep 11, 2017

if err != nil {
return err
}
err = cmd.communication.Publish("node-register", []byte(options.NodeKey))

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Sep 11, 2017

Member

What about using constants for event names?

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 12, 2017

Author Member

Implemented constants

@Waldz Waldz merged commit d0bc78a into master Sep 12, 2017

@Waldz Waldz deleted the feature/MYST-20-communication-channel branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.