Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors handling #302

Merged
merged 2 commits into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Jul 20, 2018

Handling of some errors was ignored in several places.

Better errors handling added
Signed-off-by: Dmitry Shihovtsev <soffokulus@gmail.com>

@soffokl soffokl requested review from donce, tadovas and Waldz as code owners Jul 20, 2018

@Waldz

Waldz approved these changes Jul 23, 2018

@Waldz

This comment has been minimized.

Copy link
Member

commented Jul 23, 2018

What tool do You use to identify unhandled errors?

@tadovas
Copy link
Member

left a comment

LGTM. Thanks

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2018

@Waldz it just errcheck, but it's much easy to use it with tools like golangci-lint or gometalinter.
Both of them could be easily integrated to most of editors or IDE.

@tadovas tadovas merged commit 3385dc5 into mysteriumnetwork:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.