Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/Merge client and server network options into single structure #303

Conversation

Projects
None yet
3 participants
@tadovas
Copy link
Member

commented Jul 24, 2018

  1. New testnet option introduced (overrides any previously defined localnet)
  2. Client and server network options now share common structure
  3. Fuction to parse options from flags
  4. Function to construct network definition from provided options

@tadovas tadovas requested review from interro, Waldz and zolia Jul 24, 2018

@tadovas tadovas requested a review from donce as a code owner Jul 24, 2018

@tadovas tadovas force-pushed the improvement/merge-server-client-network-options-into-single-place branch from 92378a1 to 2cde645 Jul 24, 2018

flags.BoolVar(
&options.Testnet,
"testnet",
false,

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 25, 2018

Member

But testnet is true by default

This comment has been minimized.

Copy link
@tadovas

tadovas Jul 25, 2018

Author Member

Fixed. False -> true

@Waldz

Waldz approved these changes Jul 25, 2018

@zolia

zolia approved these changes Jul 25, 2018

@tadovas tadovas merged commit 741d8eb into master Jul 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the improvement/merge-server-client-network-options-into-single-place branch Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.