Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from glide to dep #319

Merged
merged 4 commits into from Aug 28, 2018

Conversation

Projects
None yet
4 participants
@soffokl
Copy link
Member

commented Aug 24, 2018

No description provided.

@soffokl soffokl added the enhancement label Aug 24, 2018

@soffokl soffokl self-assigned this Aug 24, 2018

@soffokl soffokl requested review from tadovas and Waldz as code owners Aug 24, 2018


[[prune.project]]
name = "github.com/ethereum/go-ethereum"
unused-packages = false

This comment has been minimized.

Copy link
@tadovas

tadovas Aug 24, 2018

Member

New line expected

This comment has been minimized.

Copy link
@soffokl

soffokl Aug 24, 2018

Author Member

Added

go-tests = true
unused-packages = true

[[prune.project]]

This comment has been minimized.

Copy link
@tadovas

tadovas Aug 24, 2018

Member

Global unused-packages is a little evil I agree - so no we can specificy this flag per dependency? It would be a bit tricky to track if we need this flag for specific depedency or not - especially if it has transitive dependencies. and this flag is very important if package uses cgo - as any .c .h files will be pruned if this flag is true. That's a bit of consideration

This comment has been minimized.

Copy link
@soffokl

soffokl Aug 24, 2018

Author Member

Yeah, now it can be used for per project configuration.
Regarding cases when we need to save unused-packages, I think, we should use it only when something does not work without it. It keeps a vendor directory much smaller.

This comment has been minimized.

Copy link
@tadovas

tadovas Aug 24, 2018

Member

Alright. That's a new feature I guess? As long as I remember it was global flag only

This comment has been minimized.

Copy link
@soffokl

soffokl Aug 24, 2018

Author Member

Not sure when it was introduced.
Found the only bug when it was broken: golang/dep#1561 )

@soffokl soffokl force-pushed the experiment/glide-to-dep branch from 76730d7 to 640b213 Aug 24, 2018

@soffokl soffokl changed the title [WIP] Migration from glide to dep Migration from glide to dep Aug 24, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@@ -38,8 +34,8 @@ jobs:
- stage: dep-cache
name: "Vendor update"
script:
- source bin/travis_scripts/ensure_glide.sh $BUILD_TOOLS_PATH "v0.13.1"
- glide "-home" $GLIDE_HOME install
- curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh

This comment has been minimized.

Copy link
@Waldz

Waldz Aug 24, 2018

Member

What about go get .. way?

This comment has been minimized.

Copy link
@soffokl

soffokl Aug 24, 2018

Author Member

It is strongly recommended that you use a released version.

And go get requires to get sources and build it, so it probably a bit slower than download just binary.

@@ -6,7 +6,7 @@
* **Step 1.** Get project dependencies
```bash
brew install go
brew install glide
brew install dep

This comment has been minimized.

Copy link
@Waldz

Waldz Aug 24, 2018

Member

We collect our development dependencies into node-builder image here bin/builder_docker/Dockerfile

@soffokl soffokl dismissed stale reviews from Waldz, zolia, and tadovas via 32065b7 Aug 27, 2018

@soffokl soffokl force-pushed the experiment/glide-to-dep branch 2 times, most recently from 32065b7 to 3a0251f Aug 27, 2018

soffokl added some commits Aug 24, 2018

@soffokl soffokl force-pushed the experiment/glide-to-dep branch from 3a0251f to c031903 Aug 28, 2018

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2018

@Waldz, @tadovas, @zolia could you please review it again, I have rebased it to master.

@tadovas
Copy link
Member

left a comment

LGTM

@zolia

zolia approved these changes Aug 28, 2018

@tadovas tadovas merged commit 806e10b into master Aug 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the experiment/glide-to-dep branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.