Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-304. Enabled data race detector for unit tests #322

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Aug 27, 2018

Some tests were fixed to allow passing with enabled data race detector.

@soffokl soffokl added the enhancement label Aug 27, 2018

@soffokl soffokl self-assigned this Aug 27, 2018

@soffokl soffokl requested review from tadovas and Waldz as code owners Aug 27, 2018

@tadovas
Copy link
Member

left a comment

LGTM. Let's race!


go openvpnClientWaiter(openvpnClient, dialog)
go manager.consumeOpenvpnStates(stateChannel, vpnSession.ID)
return nil
}

func (manager *connectionManager) Status() ConnectionStatus {
manager.mutex.RLock()

This comment has been minimized.

Copy link
@Waldz

Waldz Aug 28, 2018

Member

Is there a point to block simultaneous status checks?

This comment has been minimized.

Copy link
@soffokl

soffokl Aug 28, 2018

Author Member

This is only read-lock, multiple reads can be done at the same time.
The point for this lock was a complaint by the data race detector.

@Waldz

Waldz approved these changes Aug 28, 2018

@soffokl soffokl merged commit 46f8222 into master Aug 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soffokl soffokl deleted the race-detector branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.