Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed of building docker images for Ubuntu #328

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Sep 5, 2018

No description provided.

@soffokl soffokl requested review from tadovas and Waldz Sep 5, 2018

@tadovas

tadovas approved these changes Sep 5, 2018

Copy link
Member

left a comment

Docker images should use output of xgo build not try to rebuild everything themselves - for future reference

@Waldz

Waldz approved these changes Sep 5, 2018

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2018

@tadovas looks like it's faster to build every time, then pass binaries via the cache, with these staged builds.

@soffokl soffokl self-assigned this Sep 5, 2018

@soffokl soffokl added the bug label Sep 5, 2018

@soffokl soffokl merged commit 8a591ef into master Sep 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the hotfix/ubuntu-builds branch Sep 5, 2018

soffokl added a commit that referenced this pull request Sep 6, 2018

Merge pull request #328 from mysteriumnetwork/hotfix/ubuntu-builds
Fixed of building docker images for Ubuntu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.