Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple openvpn #371

Merged
merged 12 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@vkuznecovas
Copy link
Contributor

commented Sep 17, 2018

The openvpn folder now knows nothing of the repo above.

closes #341

vkuznecovas added some commits Sep 12, 2018

@vkuznecovas vkuznecovas requested review from tadovas and Waldz as code owners Sep 17, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@Waldz

This comment has been minimized.

Copy link
Member

commented Sep 17, 2018

  • Remove commit "decoupled openvpn/linux from node/utils"
  • Remove commit "removed utils in openvpn"

vkuznecovas added some commits Sep 12, 2018

@vkuznecovas vkuznecovas force-pushed the vkuznecovas:decouple-openvpn branch from fd8847d to cd64b8c Sep 17, 2018

)

// OpenVPNServiceConfigProvider is a service config provider for openvpn
type OpenVPNServiceConfigProvider struct {

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 17, 2018

Member

This struct looks unnecessary, I would moce al concept ofl openvpn.ClientConfigGenerator to our side

vkuznecovas added some commits Sep 17, 2018

@Waldz

Waldz approved these changes Sep 17, 2018

@tadovas
Copy link
Member

left a comment

ReReLGTMed

@Waldz Waldz merged commit 13630ea into mysteriumnetwork:master Sep 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.