Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to go openvpn #379

Merged
merged 3 commits into from Sep 18, 2018

Conversation

Projects
None yet
3 participants
@vkuznecovas
Copy link
Contributor

commented Sep 18, 2018

We'll now depend on go-openvpn.

Closes #344

@vkuznecovas vkuznecovas requested review from tadovas, Waldz and soffokl Sep 18, 2018

@tadovas
Copy link
Member

left a comment

Looks ok. Just new line and will be LGTMed


[[constraint]]
name = "github.com/mysteriumnetwork/go-openvpn"
version = "0.0.5"

This comment has been minimized.

Copy link
@tadovas

tadovas Sep 18, 2018

Member

new line missing

@@ -23,11 +23,11 @@ import (
"testing"
"time"

"github.com/mysteriumnetwork/go-openvpn/openvpn"
"github.com/mysteriumnetwork/go-openvpn/openvpn/middlewares/state"

This comment has been minimized.

Copy link
@tadovas

tadovas Sep 18, 2018

Member

I hate then some internal process specific middleware leaks into connection manager :( todo later.

@vkuznecovas vkuznecovas force-pushed the vkuznecovas:move-to-go-openvpn branch from 6b4e34b to ac33305 Sep 18, 2018

@soffokl
Copy link
Member

left a comment

Looks good to me

@vkuznecovas vkuznecovas force-pushed the vkuznecovas:move-to-go-openvpn branch 2 times, most recently from 6aead86 to e25ed61 Sep 18, 2018

vkuznecovas added some commits Sep 18, 2018

@vkuznecovas vkuznecovas force-pushed the vkuznecovas:move-to-go-openvpn branch from e25ed61 to 8567837 Sep 18, 2018

@tadovas
Copy link
Member

left a comment

LGTM

@vkuznecovas vkuznecovas merged commit 44d95da into mysteriumnetwork:master Sep 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.