Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity check disabled by default, added flag to enable it. #363 #383

Merged
merged 4 commits into from Sep 19, 2018

Conversation

Projects
None yet
4 participants
@soffokl
Copy link
Member

commented Sep 19, 2018

No description provided.

@soffokl soffokl added this to the Paid identity POC milestone Sep 19, 2018

@soffokl soffokl self-assigned this Sep 19, 2018

@soffokl soffokl requested review from tadovas, Waldz, zolia and vkuznecovas Sep 19, 2018

@@ -22,6 +22,8 @@ type OptionsNetwork struct {
Testnet bool
Localnet bool

IdentityCheck bool

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 19, 2018

Member

I would like these options to have experiment prefix or suffix. Because we will be deleting them later

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 19, 2018

Author Member

Agree, fixed it.

This comment has been minimized.

Copy link
@tadovas

tadovas Sep 19, 2018

Member

👍 absolutely

@soffokl soffokl force-pushed the experiment-identity-check branch from 773dbbe to 42b7634 Sep 19, 2018

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2018

Fixed tests, extra review required :)

@Waldz

Waldz approved these changes Sep 19, 2018

@zolia

zolia approved these changes Sep 19, 2018

@soffokl soffokl merged commit c358cfd into release/0.3 Sep 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the experiment-identity-check branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.