Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme.md to fit latest release and iptables rule fix backport #393

Merged
merged 9 commits into from Sep 24, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Sep 20, 2018

iptables rule fix was introduced added here: #388

INSTALL.md partially updated. There should be another update after fixing #395

@soffokl soffokl self-assigned this Sep 20, 2018

@soffokl soffokl requested review from tadovas, Waldz, zolia and vkuznecovas Sep 20, 2018

README.md Outdated
@@ -31,11 +31,11 @@ Go to [docker](https://www.docker.com/) on how to get a recent docker version fo

### Running
```bash
sudo docker run --cap-add NET_ADMIN --net host --name mysterium-node -d mysteriumnetwork/mysterium-node:latest --agreed-terms-and-conditions
sudo docker run --cap-add NET_ADMIN --net host --name myst -d mysteriumnetwork/myst service

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

Your forget terms and conditions

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 20, 2018

Author Member

But there is no --agreed-terms-and-conditions for myst binary.
I thought it was removed purposely.

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

:O No, it should be there

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 20, 2018

Author Member

ok, I'll try to return it back )

},
Action: func(ctx *cli.Context) error {
if !ctx.Bool(agreedTermsConditionsFlag.Name) {
fmt.Println(metadata.VersionAsSummary(metadata.LicenseCopyright(
"run program with '--license.warranty' option",

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

should be run program with 'myst {licenseCommand.name} {warantFlag.name}' and same with conditions

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 20, 2018

Author Member

fixed

"run program with '--license.conditions' option",
)))
fmt.Println()
return fmt.Errorf("If you agree with these Terms & Conditions, run program again with '--agreed-terms-and-conditions' flag")

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

Is it possible to do fmt.Println() and os.Exit(2)

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 20, 2018

Author Member

added os.Exit(2)

soffokl added some commits Sep 19, 2018

@soffokl soffokl force-pushed the backport branch from 990f3ab to a9ef963 Sep 20, 2018

licenceCmd := license.NewCommand("")

fmt.Println(metadata.VersionAsSummary(metadata.LicenseCopyright(
"run program with 'myst "+licenceCmd.Name+" --"+licenceCmd.Flags[0].GetName()+"' option",

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

I suggest making flags from license public.

@@ -107,3 +124,15 @@ func NewCommand() *cli.Command {
},
}
}

func printWarning() {
licenceCmd := license.NewCommand("")

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

Inject license command, from upper layer instead of constructing it once again

"os"

"github.com/urfave/cli"

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

Extra line?

@@ -107,3 +124,15 @@ func NewCommand() *cli.Command {
},
}
}

func printWarning() {

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 20, 2018

Member

printTermWarning()

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2018

@Waldz requested changes added.

@Waldz

Waldz approved these changes Sep 21, 2018

@Waldz

Waldz approved these changes Sep 21, 2018

@zolia

zolia approved these changes Sep 24, 2018

@soffokl soffokl merged commit e530a5b into master Sep 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soffokl soffokl deleted the backport branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.