Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #403

Merged
merged 5 commits into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@Waldz
Copy link
Member

commented Sep 24, 2018

No description provided.

@Waldz Waldz requested a review from mysteriumnetwork/core Sep 24, 2018

@Waldz Waldz requested a review from tadovas as a code owner Sep 24, 2018

@@ -23,5 +23,5 @@ if [ -z "$COMMAND" ]; then
fi

docker run --rm -ti \
-v $(pwd):/go/src/github.com/mysteriumnetwork/node mysteriumnetwork/mysterium-node-builder \
-c "cd /go/src/github.com/mysteriumnetwork/node && ${COMMAND}"
-v $(pwd):/go/src/github.com/mysteriumnetwork/node \

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 25, 2018

Member

Default working directory is /go/src/github.com/mysterium/node which does not exist at the moment.
We can rebuild docker image or just change the working directory during the start time.

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Author Member

Yes, I rebuilt builder image

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 25, 2018

Member

hm, but it failed on CI

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Author Member

Failed to push. Fixed

@Waldz Waldz self-assigned this Sep 25, 2018

@Waldz Waldz force-pushed the Waldz:feature/ci-improvements branch from 354a2bf to 471c0b7 Sep 25, 2018

Waldz added some commits Sep 24, 2018

@Waldz Waldz force-pushed the Waldz:feature/ci-improvements branch from 5d9b377 to 16e0bfd Sep 25, 2018

@soffokl
Copy link
Member

left a comment

Looks good to me.

@zolia

zolia approved these changes Sep 26, 2018

Waldz added some commits Sep 26, 2018

@Waldz Waldz merged commit 2f38edd into mysteriumnetwork:master Sep 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Waldz Waldz deleted the Waldz:feature/ci-improvements branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.