Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed building of client and server, only myst left #406

Merged
merged 2 commits into from Sep 30, 2018

Conversation

@soffokl
Copy link
Member

commented Sep 25, 2018

No description provided.

@soffokl soffokl added the enhancement label Sep 25, 2018

@soffokl soffokl self-assigned this Sep 25, 2018

@soffokl soffokl requested review from zolia and vkuznecovas Sep 25, 2018

@soffokl soffokl requested review from tadovas and Waldz as code owners Sep 25, 2018

Makefile Outdated
@@ -25,14 +21,8 @@ dep:
dep-ensure:
dep ensure

server:
myst:
./bin/server_build

This comment has been minimized.

Copy link
@vkuznecovas

vkuznecovas Sep 25, 2018

Contributor

aren't you removing this file?

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 25, 2018

Author Member

Fixed.

Makefile Outdated
@@ -25,14 +21,8 @@ dep:
dep-ensure:
dep ensure

server:
./bin/server_build
myst:

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

Suggest build

Makefile Outdated

client-image:
docker build -t $(CLIENT_IMAGE_NAME) -f $(CLIENT_DOCKERFILE) .
myst-image:

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

Suggest build-image + reuse docker building script

alias myst-broker="myst-home && docker-compose up broker"
alias myst-nats="myst-broker"

alias myst-client="myst-home && bin/client_build && bin/client_run"

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

I use these aliases, can we leave them, but just proxy to different binary

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 26, 2018

Author Member

It looks more like a personal stuff. Should we keep it in public repo?

This comment has been minimized.

Copy link
@zolia

zolia Sep 28, 2018

Member

yech, you can make personal aliases through bash..

bin/ip2asn Outdated
@@ -1,23 +0,0 @@
#!/bin/bash

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

Can we leave this helper, might be useful later

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 26, 2018

Author Member

I don't really like to keep things "just in case" in a public repo.
It makes a repo looks littered.

bin/ip_info Outdated
#> bin/ip2info
#
# Lookup info of given IP:
#> bin/ip2info 216.58.209.110

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

same here


docker_release_image myst:alpine mysteriumnetwork/mysterium-node:${VERSION_TAG}
docker_release_image myst:alpine mysteriumnetwork/mysterium-node:${VERSION_TAG}-alpine
docker_release_image myst:ubuntu mysteriumnetwork/mysterium-node:${VERSION_TAG}-ubuntu

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

Are we stopping support for mysterium-node image?
Because internet is full of instructions how to setup it like here https://github.com/mysteriumnetwork/node/wiki/Links

Maybe we should push dummy image which says "You should be migrate to mysteriumnetwork/myst service --agreed-terms-and-conditions"

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 26, 2018

Author Member

We will still have the building of mysterium-node images in the release/0.2 branch, so images will be active.
Placing a dummy image that recommends using newer version should be done only after we finally deprecate 0.2.* versions and stop doing any fixes there.
I think it should be done a bit latter.

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 26, 2018

Member

now You clarified. @zolia @tadovas take a look

@@ -1,83 +0,0 @@
#!/bin/bash

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 25, 2018

Member

Is it possible to git mv instead copy&delete. To keep Git history somehow

This comment has been minimized.

Copy link
@soffokl

soffokl Sep 26, 2018

Author Member

I have tried a number of ways, but Github does not show proper history in all cases.
Anyway, we have issue for replacing these scripts with a go implementation: #361.
So it will be lost in history anyway in a short time.

@soffokl soffokl force-pushed the myst-binary-only branch from ca8bd45 to 44c385c Sep 26, 2018

@soffokl soffokl requested a review from vkuznecovas Sep 26, 2018

@soffokl soffokl force-pushed the myst-binary-only branch from 44c385c to 9a8ac35 Sep 27, 2018

@soffokl soffokl requested review from vkuznecovas and Waldz Sep 27, 2018

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2018

@Waldz @vkuznecovas @zolia I have rebased it to the master. Please take a look on this once again.

@Waldz Waldz added this to the Paid identity POC milestone Sep 27, 2018

@zolia

zolia approved these changes Sep 28, 2018

Copy link
Member

left a comment

lgtm

@soffokl soffokl dismissed stale reviews from zolia and vkuznecovas via 7558564 Sep 28, 2018

@Waldz

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

Dont forget to remove from https://github.com/MysteriumNetwork/build-artifacts

@zolia

zolia approved these changes Sep 28, 2018

cp -vrp "bin/common_package/" ${DST_DIR}/config
if [[ -d "bin/client_package/config/${OS_DIR}/" ]]; then
cp -vrp "bin/client_package/config/${OS_DIR}/." ${DST_DIR}/config
cp -vrp "bin/package/config/common/" ${DST_DIR}/config

This comment has been minimized.

Copy link
@Waldz

Waldz Sep 28, 2018

Member

I registered related bug #415

@Waldz

Waldz approved these changes Sep 28, 2018

@soffokl soffokl merged commit 774fbff into master Sep 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soffokl soffokl deleted the myst-binary-only branch Oct 1, 2018

soffokl added a commit that referenced this pull request Oct 1, 2018

soffokl added a commit that referenced this pull request Oct 1, 2018

soffokl added a commit that referenced this pull request Oct 2, 2018

Merge pull request #418 from mysteriumnetwork/release-03-fixes
Backport of configuration fixes from #406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.