Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved to gofrs/uuid instead of satori/uuid #422

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@vkuznecovas
Copy link
Contributor

commented Oct 2, 2018

closes #376

@vkuznecovas vkuznecovas requested review from Waldz, soffokl and zolia Oct 2, 2018

@vkuznecovas vkuznecovas requested a review from tadovas as a code owner Oct 2, 2018

@soffokl
Copy link
Member

left a comment

Looks good to me.


// GenerateUUID method returns ID based on random UUID
func GenerateUUID() ID {
return ID(uuid.NewV4().String())
return ID(uuid.Must(uuid.NewV4()).String())

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 2, 2018

Member

Lets not crash full app, but handle error

@vkuznecovas vkuznecovas dismissed stale reviews from soffokl and Waldz via 149bfc8 Oct 3, 2018

@vkuznecovas vkuznecovas force-pushed the techdebt/move-from-satori branch from f65d2dd to 149bfc8 Oct 3, 2018

@@ -102,7 +102,11 @@ func (manager *manager) Create(consumerID identity.Identity, proposalID int) (se
}

func (manager *manager) createSession(consumerID identity.Identity) (sessionInstance Session, err error) {
sessionInstance.ID = manager.generateID()
id, err := manager.generateID()

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 3, 2018

Member

Put directly to sessionInstance.ID, dont need temp variable here

This comment has been minimized.

Copy link
@vkuznecovas

vkuznecovas Oct 3, 2018

Author Contributor

fixd

@vkuznecovas vkuznecovas force-pushed the techdebt/move-from-satori branch from 149bfc8 to 6c2db39 Oct 3, 2018

@Waldz

Waldz approved these changes Oct 4, 2018

@soffokl

soffokl approved these changes Oct 4, 2018

@vkuznecovas vkuznecovas merged commit 23d2ce2 into master Oct 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vkuznecovas vkuznecovas deleted the techdebt/move-from-satori branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.