Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push master to dev pre-release #423

Merged
merged 3 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Oct 3, 2018

Closes #416

@soffokl soffokl added the enhancement label Oct 3, 2018

@soffokl soffokl self-assigned this Oct 3, 2018

@soffokl soffokl requested review from Waldz, zolia and vkuznecovas Oct 3, 2018

@soffokl soffokl requested a review from tadovas as a code owner Oct 3, 2018

.travis.yml Outdated
- dep-cache
- test
- name: dep-cache
if: tag != dev

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 3, 2018

Member

we dont need to cache for dev?

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 3, 2018

Author Member

We are introducing dev tag in the release-dev stage. When the new tag appears Travis starts a new build for this tag. This condition just prevents this run the second time.

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 3, 2018

Member

Sounds very complicated, how to make readable about this side effect?

.travis.yml Outdated
- name: build
if: (type != pull_request AND branch = master AND tag IS blank) OR tag IS present
if: (type != pull_request AND branch = master AND tag IS blank) OR (tag IS present AND tag != dev)

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 3, 2018

Member

Should not we run build together with release. Would simplify variable hell

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 3, 2018

Author Member

We are introducing dev tag in the release-dev stage. When the new tag appears Travis starts a new build for this tag. This condition just prevents this run the second time.

@@ -95,14 +97,21 @@ jobs:
- stage: release-dev
script: bin/s3 sync s3://build-artifacts build/package
name: "Update for build-artifacts"
before_deploy:
- git tag -f dev

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 3, 2018

Member

Dont You want to add this to script?

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 3, 2018

Author Member

I think that it's more readable to keep it here.
It's not too big to have an extra script for that, and it never used for the second time somewhere else.

@vkuznecovas

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2018

I feel we also need to include commit hashes with the packages(either on each of them, or somehow incorporate that into the bucket itself). Here's a scenario of why I think this is needed:

As a user, I'll open up the dev-release page(the s3 bucket in this case) - and I'll see all the packages - issue here is that I won't know the commit they are coming from. I might end up running a version that I think is the newest, although the packages have not been updated in the bucket yet.

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2018

@vkuznecovas I believe that commit ID should be built into the binary itself, not archive name. And looks like we already have it.

@vkuznecovas

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2018

I'll still be downloading a version without knowing if it's the latest though :/

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2018

There will be a single option to download dev version, only the latest one, no other options.

@soffokl soffokl force-pushed the dev-pre-release branch from 22c61fa to 0e667ed Oct 4, 2018

@soffokl soffokl force-pushed the dev-pre-release branch from 0e667ed to bd9b502 Oct 4, 2018

@Waldz

Waldz approved these changes Oct 5, 2018

@@ -93,23 +93,10 @@ jobs:

# Development bleeding-edge release (on master commits only)
- stage: release-dev

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 5, 2018

Member

It's not release anymore. It's just single bin/release_goreport task

@Waldz

Waldz approved these changes Oct 5, 2018

@soffokl soffokl merged commit 4bfd585 into master Oct 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soffokl soffokl deleted the dev-pre-release branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.