Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed travis stages #427

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Oct 4, 2018

The "End-to-end tests" job in the test stage have a condition for running only on pull requests.
And if we are running build without pull request whole test stage is ignored because of this condition and other jobs going to stage for getting dependencies. And sometimes jobs starting before dependencies properly downloaded.
This PR changes the order of jobs in test stage to skip only "E2E tests" for non pull requests builds.

@soffokl soffokl added the bug label Oct 4, 2018

@soffokl soffokl self-assigned this Oct 4, 2018

@soffokl soffokl requested review from Waldz, zolia and vkuznecovas Oct 4, 2018

@soffokl soffokl requested a review from tadovas as a code owner Oct 4, 2018

script: bin/test
name: "Unit tests"

- script: bin/test_e2e

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 4, 2018

Member

I made this change recently.
Why not to start slowest job as soon as possible?

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 4, 2018

Author Member

Travis starts 5 jobs at the same time, I don't think that it will slow down anything. I have moved it because it has a condition, that breaks the CI process. Details described in the PR note.

@Waldz

Waldz approved these changes Oct 5, 2018

@soffokl soffokl merged commit 04eb2e2 into master Oct 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soffokl soffokl deleted the travis-stages-fix branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.