Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build version for deb packages #430

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@soffokl
Copy link
Member

commented Oct 9, 2018

No description provided.

@soffokl soffokl added the bug label Oct 9, 2018

@soffokl soffokl self-assigned this Oct 9, 2018

@soffokl soffokl requested review from Waldz, zolia and vkuznecovas Oct 9, 2018

@soffokl soffokl requested a review from tadovas as a code owner Oct 9, 2018

@soffokl soffokl force-pushed the hotfix/build-version-deb branch from 3e59bef to b814283 Oct 9, 2018

@@ -11,7 +11,7 @@ env:
- BUILD_VERSION_MAJOR=0

before_install:
- export BUILD_VERSION=${TRAVIS_TAG:-"$BUILD_VERSION_MAJOR-dev.$TRAVIS_BUILD_NUMBER"}
- if [ -z "${TRAVIS_TAG/dev/}" ]; then export BUILD_VERSION="$BUILD_VERSION_MAJOR-dev.$TRAVIS_BUILD_NUMBER"; fi

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 9, 2018

Member

Lets tag our prerelease with 0-dev, 0.0.0-dev or 0.4-dev and we dont need this conditional anymore

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 9, 2018

Author Member

0-dev and 0.0.0-dev looks weird for me. dev means development version.
0.4-dev is nice, but it will require a manual change after every major release.
Do you think that it's better than this condition?

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 9, 2018

Member

I dont know. But this condition brings problems, not 1st time

@Waldz

Waldz approved these changes Oct 9, 2018

@soffokl soffokl merged commit 7712724 into master Oct 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soffokl soffokl deleted the hotfix/build-version-deb branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.