Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run goimports with builder #452

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
4 participants
@tadovas
Copy link
Member

commented Oct 16, 2018

Closes #450
Run check_goimports inside preinstalled builder container

@tadovas tadovas requested review from Waldz and soffokl Oct 16, 2018

@tadovas

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

This looks really important, as I already found one go file which was not "goimported"

@tadovas

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

@mysteriumnetwork/core @Waldz @soffokl check this as priority

signerCreate: signerCreate,
statusChan: make(chan Status),
status: StatusUndefined,
identityRegistry: identityRegistry,

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 16, 2018

Member

This was formatted by goimports in my system. Maybe we have some old version of goimports in the build image?

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 16, 2018

Member

Found it, I was using old version from https://github.com/bradfitz/goimports

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 16, 2018

Member

or not
sorry for these comments fall :(

@@ -48,7 +48,7 @@ jobs:
- script: bin/builder_run bin/check_golint
name: "golint check"

- script: bin/check_goimports
- script: bin/builder_run bin/check_goimports

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 16, 2018

Member

I'd try to avoid using extra pre-build images for simple task.
Maybe it's better to do go get goimports instead of running it in extra docker container?

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 16, 2018

Member

And looks like direct call works a bit faster on my system:
image

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 16, 2018

Member

This ^ was not counting time for image downloading.

This comment has been minimized.

Copy link
@tadovas

tadovas Oct 16, 2018

Author Member

Your points are absolutely valid, but:

  1. It's not improvement or feature, its a hotfix - intention was to fix it asap with minimal effort as build functionality is currently broken
  2. golint is also go getted inside builder and is run the same way, maybe we can get rid of this builder completely when migrating to go style CI
@Waldz

Waldz approved these changes Oct 17, 2018

@tadovas tadovas merged commit fccf149 into master Oct 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the hotfix/reenable-goimports branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.