Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise when running `check_golint` #457

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@tcharding
Copy link
Contributor

commented Oct 17, 2018

Currently check_golint script prints a bunch (5) of warning lines when there are no messages to warn about, such as this (including the newlines):

[warning] 0 messages in 'github.com/mysteriumnetwork/node/identity': 


This is a off putting; if there are no issues there should be no output. If 0 messages implies some error then we should warn about that explicitly (I don't know if this is the case so this patch takes the first route).

Only print warning message if there are more than 0 messages to show.

Signed-off-by: Tobin C. Harding me@tobin.cc

@tcharding tcharding requested review from tadovas and Waldz as code owners Oct 17, 2018

Only show warning if package message count is > 0
Signed-off-by: Tobin C. Harding <me@tobin.cc>
@soffokl

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

Hm, I see no [warning] 0 messages. Maybe it's related to golint version or something else?
image

@tcharding

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2018

This is linked to #458 it shows up because golint is failing for me so there are 0 warnings. It will also show up when we have the whole codebase linting cleanly ;)

@soffokl
Copy link
Member

left a comment

Looks good to me.

@Waldz

Waldz approved these changes Oct 18, 2018

@Waldz Waldz merged commit 11eca99 into mysteriumnetwork:master Oct 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tcharding tcharding deleted the tcharding:check_golint-warn branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.