Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myst cli does not start new daemon #475

Merged
merged 2 commits into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@soffokl
Copy link
Member

commented Oct 23, 2018

Closes #402

@soffokl soffokl self-assigned this Oct 23, 2018

@soffokl soffokl requested review from Waldz, zolia and vkuznecovas Oct 23, 2018

@soffokl soffokl requested a review from tadovas as a code owner Oct 23, 2018

@tadovas
Copy link
Member

left a comment

Is it also related with hanging terminal bug when exiting cli ?
I like lines removed count :)

@soffokl

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

@tadovas no, it's not related. Hanging problem described here.

return &cli.Command{
Name: cliCommandName,
Usage: "Starts a CLI client with a Tequilapi",
Action: func(ctx *cli.Context) error {
errorChannel := make(chan error)
if err := di.Bootstrap(cmd.ParseFlagsNode(ctx)); err != nil {

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 23, 2018

Member

Is it possible to remove Node bootstrapping for myst service command also?

This comment has been minimized.

Copy link
@soffokl

soffokl Oct 23, 2018

Author Member

But what will the service do without Node?
I think it will be not comfortable to start daemon and service separately.

And we have issue #431, that will allow using service with existing daemon.

This comment has been minimized.

Copy link
@Waldz

Waldz Oct 23, 2018

Member

But what will the service do without Node?

Well flow should be: myst daemon --data-dir.. and myst service

@Waldz

Waldz approved these changes Oct 23, 2018

@Waldz Waldz merged commit 706fe75 into master Oct 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Waldz Waldz deleted the revert-cli-daemon branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.