Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session stats are now reset #617

Merged
merged 1 commit into from Dec 14, 2018
Merged

session stats are now reset #617

merged 1 commit into from Dec 14, 2018

Conversation

vkuznecovas
Copy link
Contributor

@vkuznecovas vkuznecovas commented Dec 14, 2018 •
edited

CLOSES #616.

taken from #616

Currently, the stats trackers session statistics are never reset. This results in a scenario where I can:

  1. start a connection that tracks statistics(openvpn).
  2. wait a bit until stats are accumulated.
  3. disconnect
  4. connect to a connection that does not track statistics(noop).
  5. noop now sends out statistics with the byte count from openvpn instead of zeros, as it's supposed to do.

@zolia zolia merged commit 2571549 into master Dec 14, 2018
@zolia zolia deleted the bug/session-stats-reset branch December 14, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soffokl soffokl soffokl approved these changes

@zolia zolia zolia approved these changes

@tadovas tadovas Awaiting requested review from tadovas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vkuznecovas @soffokl @zolia