Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYST-179 Create Docker container with minimal Alpine image #72

Merged
merged 15 commits into from Jan 4, 2018

Conversation

Projects
None yet
4 participants
@Waldz
Copy link
Member

commented Dec 27, 2017

No description provided.

@Waldz Waldz force-pushed the feature/MYST-179-docker-with-alpine branch from f5fcefb to 83324b5 Dec 27, 2017

@@ -32,7 +32,7 @@ Running
------------
``` bash
# Start communication gateway
docker-compose up gateway
docker-compose up broker

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Dec 27, 2017

Member

Are we considering to officially name it broker? :)

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 4, 2018

Author Member

Yes, such recommendation was in the air

@@ -0,0 +1,15 @@
FROM ubuntu:16.04
MAINTAINER Valdas Petrulis <petrulis.valdas@gmail.com>

This comment has been minimized.

Copy link
@ignasbernotas

ignasbernotas Dec 27, 2017

Member

Personal email intended?:) Just in case you missed it.

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 4, 2018

Author Member

Yes, I dont care

@@ -1 +1,2 @@
MYSTERIUM_API_URL=<url>
NATS_SERVER_IP=127.0.0.1

This comment has been minimized.

Copy link
@tadovas

tadovas Dec 27, 2017

Member

Why do we still need nats server ip at compile time instead of passing it at least on runtime command args?

This comment has been minimized.

Copy link
@Waldz

Waldz Jan 4, 2018

Author Member

Currently compile args is the only injection engine.
Not sure if passing args is what we want, as we need some defaults.

@zolia
Copy link
Member

left a comment

looks good, will enable us to make integrity tests without much effort.

@Waldz Waldz force-pushed the feature/MYST-179-docker-with-alpine branch from 83324b5 to 2149490 Jan 4, 2018

@zolia

zolia approved these changes Jan 4, 2018

@zolia zolia merged commit 615ea9a into master Jan 4, 2018

@zolia zolia deleted the feature/MYST-179-docker-with-alpine branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.