Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support npm config params #60

Closed
vitalets opened this issue Aug 30, 2016 · 4 comments
Closed

Support npm config params #60

vitalets opened this issue Aug 30, 2016 · 4 comments

Comments

@vitalets
Copy link

In our scripts we are using $npm_config_xxx params.
for example:

"scripts": {
    "zip": "cd $npm_config_outdir && zip -rT $npm_config_outzip .",
    "crx": "crx pack $npm_config_outdir",
    "zip-crx": "npm run zip && npm run crx",
}

We can run such scripts via:

npm run zip-crx --outdir=dist --outzip=archive.zip

it would be great if npm-run-all support such npm params and not confuse it with own params or command own params.
Currently I get error:

ERROR: Invalid Option: --outdir=dist
@mysticatea
Copy link
Owner

Thank you for this issue.

I have not been aware of that feature of npm. (though npm-run-all supports $npm_package_config_xxx variables since #13).
I will do.

@vitalets
Copy link
Author

vitalets commented Sep 1, 2016

Thanks a lot for quick reply and actions!
When you plan to release?

@mysticatea
Copy link
Owner

Just now, I released v3.1.0 😄
Please tell me if there are problems.

Thank you!

@airtonix
Copy link

This needs to be reverted. it was poorly planned and thought out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants