New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Lists and CommonMark #19

Open
jessehouwing opened this Issue Jun 7, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jessehouwing

jessehouwing commented Jun 7, 2018

I've used this wonderful converter to migrate my blog from Blogger to Ghost and I ran into a few small issues:

  1. nested lists don't work after migration. Ghost uses CommonMark which requires deeper indentation. I think this would be easy to fix, especially if the indentation could be made configurable right here: https://github.com/mysticmind/reversemarkdown-net/blob/master/src/ReverseMarkdown/Converters/Li.cs Or at least by making the method that gets the indentation protected so I can easily change the behaviour.
  2. code blocks. CommonMark uses the GitHub style code blocks, but the standard <pre> converter didn't do the trick for me, it stripped all the required newlines. I ended up writing a very simple custom converter that seems to work better: https://github.com/jessehouwing/Blogger2Ghost/blob/master/Blogger2Ghost/Commands/ConvertCommand.cs#L418-L430
@mysticmind

This comment has been minimized.

Owner

mysticmind commented Jun 8, 2018

Thanks for reporting this issue. I think in general, support need to be added for handling CommonMark, will take a look at this next week.

@mysticmind

This comment has been minimized.

Owner

mysticmind commented Aug 1, 2018

@jessehouwing with regards to pre tag to GFM style code block, you can use var config = new Config(githubFlavored: true);. did you try it?

@jessehouwing

This comment has been minimized.

jessehouwing commented Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment