New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity 5 Compatibility fix #13
Conversation
|
I'm no longer actively maintaining the Spriter2Unity project and haven't done much to keep current on Unity changes in general, but I'm sure many users will appreciate your changes. |
|
Sorry for this mistake :) |
|
I wanted to verity that his changes work correctly, but that line 192 in AnimationCurveUtils.cs is not needed. |
|
The line is needed for Unity < 5. I'll post another PR |
|
Are you sure it is? The line doesn't actually do anything. The variable actually is never used anywhere. |
|
He's correct - the 4.3 version uses it as a parameter. |
|
just made a PR to fix it :) |
|
Then why isn't it in side a directive? |
|
Ah I've seen your fix. I've tried to merge your fork into mine but apparently I ran into some kind of conflict. Idk how to resolve conflicts so I just changed my fork manually. |
managed to get it working with Unity 5 :)
Here is the fixed version.
I used #Unity_5 conditional compilation switch so the old code is kept as is for older version.