Skip to content

Commit

Permalink
Remove overall contributors from retention on community metrics page
Browse files Browse the repository at this point in the history
  • Loading branch information
brittanydionigi committed Feb 29, 2016
1 parent 7270e79 commit d4245f7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions kitsune/community/templates/community/metrics.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,12 @@
{% block content %}
<article id="kpi-dash">
<h1>{{ _('Contributor Metrics') }}</h1>
<section id="kpi-cohort-analysis" data-url="/api/2/cohort">
<section id="kpi-cohort-analysis" data-url="/api/2/cohort" data-contributor-type="contributor:kb:en-US">
<h2>{{ _('Retention') }}</h2>
<div id="retention-chart" class="graph" data-chart-type="d3" data-slug="retention">
<div class="inline-controls">
<div>
<select id="toggle-cohort-type">
<option value="contributor">{{ _('Contributors') }}</option>
<option value="contributor:kb:en-US">{{ _('en-US') }}</option>
<option value="contributor:kb:l10n">{{ _('L10N') }}</option>
<option value="contributor:supportforum:helper">{{ _('Support Forum Help') }}</option>
Expand Down
3 changes: 2 additions & 1 deletion kitsune/kpi/static/kpi/js/kpi.browserify.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ function handleDataError($container) {
function makeRetentionChart(settings) {
let $container = settings.container;
let startDate = moment().day(1).day(-84).format('YYYY-MM-DD');
let defaultContributorType = $container.data('contributor-type') || 'contributor';
let urlToFetch = `${$container.data('url')}?start=${startDate}`;
let fetchDataset = getChartData(urlToFetch, 'results');
let retentionChart = new Chart($container, settings.options);
Expand All @@ -253,7 +254,7 @@ function makeRetentionChart(settings) {
retentionChart.data = data;
retentionChart.axes.yAxis.labels = _.uniq(_.pluck(data, 'start'));
retentionChart.setupAxis('yAxis');
retentionChart.populateData('contributor');
retentionChart.populateData(defaultContributorType);

$('#toggle-cohort-type').change(function() {
let cohortType = $(this).val();
Expand Down

0 comments on commit d4245f7

Please sign in to comment.