Adding options argument for all hooks #100

Merged
merged 2 commits into from Mar 9, 2013

Projects

None yet

3 participants

@jgoodson
Contributor
jgoodson commented Mar 8, 2013

Automatically calls hooks with self.config from the Engine() as the first argument, followed by the arguments passed to run_hook(). Also updates the only hook I could find in contrib/hooks.py and adds the changes to the hooks.mkd file in docs.

Owner
mythmon commented Mar 9, 2013

This looks good, thank you!

@mythmon mythmon merged commit 87ec3cd into mythmon:master Mar 9, 2013
Contributor

should've posted this on the PR

This argument could probably be passed in as a kwarg; it's backwards incompatible. And it's caused me some pain since PyPi and master aren't compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment