From f895269e5327fa8165687bed3da8bf4ea85b9e22 Mon Sep 17 00:00:00 2001 From: Makoto YUI Date: Fri, 18 Oct 2013 16:20:26 +0900 Subject: [PATCH] Fixed score calculation w.r.t bias values in predict() --- .../BinaryOnlineClassifierUDTF.java | 2 +- .../regression/OnlineRegressionUDTF.java | 2 +- target/hivemall.jar | Bin 129586 -> 129586 bytes 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/hivemall/classifier/BinaryOnlineClassifierUDTF.java b/src/main/hivemall/classifier/BinaryOnlineClassifierUDTF.java index 51410370..a6c65de7 100644 --- a/src/main/hivemall/classifier/BinaryOnlineClassifierUDTF.java +++ b/src/main/hivemall/classifier/BinaryOnlineClassifierUDTF.java @@ -200,7 +200,7 @@ protected float predict(final List features) { if(biasKey != null) { WeightValue biasWeight = weights.get(biasKey); if(biasWeight != null) { - score += biasWeight.getValue(); + score += (biasWeight.getValue() + bias); } } diff --git a/src/main/hivemall/regression/OnlineRegressionUDTF.java b/src/main/hivemall/regression/OnlineRegressionUDTF.java index 280b3f5a..c8cfe379 100644 --- a/src/main/hivemall/regression/OnlineRegressionUDTF.java +++ b/src/main/hivemall/regression/OnlineRegressionUDTF.java @@ -204,7 +204,7 @@ protected float predict(final Collection features) { if(biasKey != null) { FloatWritable biasWeight = weights.get(biasKey); if(biasWeight != null) { - score += biasWeight.get(); + score += (biasWeight.get() * bias); } } diff --git a/target/hivemall.jar b/target/hivemall.jar index 0ad5987b6c2a209fc5f92020c704bd117b03264c..f6ea8dd7707efd0343a1ccdcb29709cb1ea06f10 100644 GIT binary patch delta 33 pcmdn=g?-Z(cJ2UgW)=|!4h{~6BaPf!xfy3(VLY;Z=@rIaRRFnw3t9jG delta 33 pcmdn=g?-Z(cJ2UgW)=|!4h{|m-$w4O+>A4?F#2v^dWEr96#%Z!3TyxX