Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISO date parsing #103

Merged
merged 5 commits into from Nov 21, 2018
Merged

Fix ISO date parsing #103

merged 5 commits into from Nov 21, 2018

Conversation

@orsinium
Copy link
Contributor

@orsinium orsinium commented Oct 8, 2018

Thank you for cool library.

In some of versions between 2.5 and 2.6 python-dateutil broke ISO date parsing when dayfirst=True. Unfortunately, delorean uses True for this parameter by default. So, I've fixed it:

  1. Try to parse string as ISO date before everything else.
  2. You can disable it via isofirst=False.
  3. Added test for this case.
  4. python-dateutil version constraint now >=2.7.0, because dateutil.parser.isoparse added only in this version.

Close #101

orsinium added 5 commits Oct 8, 2018
@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Nov 5, 2018

@myusuf3, could you, please, review this PR?

@myusuf3 myusuf3 merged commit 3e8a7b8 into myusuf3:master Nov 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@myusuf3
Copy link
Owner

@myusuf3 myusuf3 commented Nov 21, 2018

@orsinium thanks for the patch and the work.

@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Nov 22, 2018

Thank you. I'm always happy to help good projects to be more stable and cool. Have a great day :)

@Evesy Evesy mentioned this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants