Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default option with default to true to clear out the vote on PR synchronize event #49

Closed
myyk opened this issue Sep 18, 2020 · 0 comments

Comments

@myyk
Copy link
Owner

myyk commented Sep 18, 2020

New votes are already triggered on

    types: [opened, synchronize, reopened] // these are defaults for pull_request_target if not specified explicitly

It would be better to make a few changes:

  1. reopened perhaps should create a new vote since maybe it was closed for a while and old votes might not make sense anymore.
  2. synchronize should somehow close other prior votes by marking them very explicitly as not an ongoing vote and create a new voting comment.
  3. If not automatic in (2) we should make sure that the new vote comment is used throughout.
@myyk myyk mentioned this issue Oct 6, 2020
@myyk myyk closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant