Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong size of playback control buttons on Jolla C #94

Open
dikonov opened this Issue Apr 26, 2018 · 5 comments

Comments

Projects
None yet
1 participant
@dikonov
Copy link

dikonov commented Apr 26, 2018

The kodimote [fork] by ade draws playback control buttons wrongly. Two of the buttons go offscreen.
See rthe attached photo. Physical size of Jolla C screen is 110x62 mm.

cimg8353
Left Jolla C, Right Jolla 1. Both running the ade's fork version of kodimote.

@dikonov

This comment has been minimized.

Copy link
Author

dikonov commented Apr 30, 2018

The new version 2.1.2-4 definitely looks better.
However Jolla C has its own screen size and pixel density. The button size for Jolla C is now physically smaller than on Jolla 1.

Another issue is that TV show names and music metadata printed below the playlist items are too big to fit in the available space. Could they be made smaller?

cimg8367
cimg8370

@dikonov

This comment has been minimized.

Copy link
Author

dikonov commented May 7, 2018

The new version correctly sizes the playback buttons (GOOD!) but
The spacing of lists is way too large. It wastes about 30% of screen space. The truth is in between 2.1.3-1 and 2.1.3-2.
jollac-too_wide

@dikonov

This comment has been minimized.

Copy link
Author

dikonov commented May 9, 2018

2.1.3-3 Makes the pacing too tight again. See the picture.
jollac-list spacing_too tight_v2 1 3-3

@dikonov

This comment has been minimized.

Copy link
Author

dikonov commented May 11, 2018

2.1.3-5 Made the list spacing even WIIIIDEEEERR.
jollac-even_wider

@dikonov

This comment has been minimized.

Copy link
Author

dikonov commented May 17, 2018

Related history of changes in apps/sailfish/qml/pages/BrowserPage.qml

2.1.3-4 Final attempt to fix list item height jolla C
8days ago - HORRIBLY LARGE spaces between list items > MEDIUM

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (126 * appWindow.sizeRatio) : (92 * appWindow.sizeRatio)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallScreen ? 200 : 126 * appWindow.sizeRatio) : (appWindow.smallScreen ? 320 : 92 * appWindow.sizeRatio)

2.1.3-3 Attempt to fix list item height jolla C
9 days - OVERLAPPING list items > HORRIBLY LARGE

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallestScreen? 126 : 126*2) : (appWindow.smallestScreen? 92 : 92*2)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (126 * appWindow.sizeRatio) : (92 * appWindow.sizeRatio)

2.1.3-2 Attempt to support jolla C (720p) resolution
11 days - MEDIUM (30%) unneeded spaces > OVERLAPPING

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallScreen? 126 : 126*2) : (appWindow.smallScreen? 92 : 92*2)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallestScreen? 126 : 126*2) : (appWindow.smallestScreen? 92 : 92*2)

2.1.2-8 Scaled Jolla C back to Jolla 1 sizing
18 days - OVERLAPPING list items > MEDIUM

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (largeScreen? 126*2 : 126) : (largeScreen? 92*2 : 92)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallScreen? 126 : 126*2) : (appWindow.smallScreen? 92 : 92*2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.