Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forked #81

Merged
merged 8 commits into from Feb 9, 2021
Merged

Forked #81

merged 8 commits into from Feb 9, 2021

Conversation

JoeCMorgan
Copy link
Contributor

Remove arrow methods from class

@JoeCMorgan
Copy link
Contributor Author

@mzohaibqc PR to remove the arrow functions. I've tested with webpack@5 and it works fine, so I don't see why it wouldn't work with webpack@4. There are still arrow functions inside the methods, however the've been in there since before version 1.3.8, so I think it was just an issue having arrow functions as class methods.

I'm not sure why github thinks there are so many file changes in this PR, as most of them are already in master 🤔

@mzohaibqc
Copy link
Owner

@JoeCMorgan your branch is not updated with master. Kindly pull master branch from main repository into your branch and it will fix too many changes.

@JoeCMorgan
Copy link
Contributor Author

Apologies, as you said I had forgotten to pull your master branch into my fork. Should be sorted now

@mzohaibqc mzohaibqc merged commit 096f08e into mzohaibqc:master Feb 9, 2021
@mzohaibqc
Copy link
Owner

@JoeCMorgan Thanks, I've merged and published a new version i.e. 1.3.9

@JoeCMorgan
Copy link
Contributor Author

@mzohaibqc No problem at all, apologies about that. I'll keep and eye on the raised issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants