feat(ci): parallelize jobs #141
Conversation
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Check formatting | ||
| run: | | ||
| for example in browser-chat browser-echo custom-router dumbpipe-web \ |
There was a problem hiding this comment.
Is it possible to keep a single list of rust examples (and one of wasm examples) in a variable at the top? With now three lists (here, above on fetch deps, below on test) it is quite error-prone to keep those in sync and up-to-date when adding new examples.
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Build WASM examples | ||
| run: | | ||
| for example in browser-echo; do |
|
Deployment for this PR has been generated and is available at: https://n0-computer.github.io/iroh-examples/pr/141 Last updated: 2025-10-23T09:38:55Z |
browser-chat/cli/Cargo.toml
Outdated
| tracing-subscriber = "0.3.19" | ||
| data-encoding = "2.9" | ||
|
|
||
| [target.'cfg(not(target_arch = "wasm32"))'.dependencies] |
There was a problem hiding this comment.
Instead can we easily make the cli not build for wasm? It's a separate crate from the shared lib and not intended to build on wasm
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Build WASM examples | ||
| run: | | ||
| # browser-echo is a single package |
There was a problem hiding this comment.
can we use the WASM_EXAMPLES_LIST from above here instead of manually invoking the build for each wasm crate?
There was a problem hiding this comment.
browser-chat is a special case but I've amended it now
| env: | ||
| SCCACHE_GHA_ENABLED: "true" | ||
| RUSTC_WRAPPER: "sccache" | ||
| example: |
There was a problem hiding this comment.
No need to hold this up, but if you happen to have an idea how to easily again use the RS_EXAMPLES_LIST from above instead of the manual list here, we'd be down to a single place where examples are listed. However if this is not straightforward, let's leave it.
Maybe we can add a note to the readme or to a CONTRIBUTING.md with instructions where you have to add the paths to new examples when contributing an example?
There was a problem hiding this comment.
sadly we cannot create a matrix dynamically so we have to maintain both or I have to do a much more complex setup which Im still not sure works.
No description provided.