upgrade s3-bao-store to irohv0.14.0 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
reviewed
Apr 22, 2024
iroh-s3-bao-store/src/lib.rs
Outdated
| let hash = outboard.root; | ||
| (outboard.into_inner_with_prefix(), hash) | ||
| }; | ||
| outboard.splice(0..8, []); |
Contributor
There was a problem hiding this comment.
Is this still necessary? I tried to remove all length prefixes in bao-tree.
Contributor
Author
There was a problem hiding this comment.
you mean line 56? I don't actually know. My only hint on this change was replacing the function for the contents since there is no info in the crate/repo about why the helper functions are no longer necessary. Maybe I could look into that with some guidance there?
rklaehn
approved these changes
Apr 29, 2024
ramfox
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates based on the changes in n0-computer/bao-tree@5ee6d91
#39