Some rephrasing in the overview. Mostly about relay servers #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matheus23
reviewed
Feb 21, 2025
matheus23
reviewed
Feb 21, 2025
Comment on lines
+35
to
+38
| Peers can also connect directly without using a relay server. | ||
| For this, | ||
| however, | ||
| the listening peer must be directly reachable by the connecting peer via one of it's addresses. |
Member
There was a problem hiding this comment.
Erm. That's some pretty aggressive newlining :D
Personally I like to do one line per sentence.
Contributor
Author
There was a problem hiding this comment.
heh, yeah. I thought the convention is also for commas. But in this case it's a bit aggressive, sure. Probably not needed, but doesn't do any harm either.
matheus23
approved these changes
Feb 21, 2025
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the function of the relay servers a bit more accurate.
Removes some duplication.