Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iroh-ctl): implement available commands #123

Merged
merged 8 commits into from Jul 1, 2022
Merged

feat(iroh-ctl): implement available commands #123

merged 8 commits into from Jul 1, 2022

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Jun 15, 2022 •
edited

Also stubs in planned commands.

closes n0-computer/beetle#280
closes n0-computer/beetle#279

@ramfox ramfox self-assigned this Jun 15, 2022
dignifiedquire
dignifiedquire reviewed Jun 16, 2022
View reviewed changes
iroh-ctl/src/p2p.rs Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire previously approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structure looks great, didn't look at each command in detail given that most are not implemented xD

Arqu
Arqu previously approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really really great stuff 🧨. Seeing it fleshed out opens my eyes on just how much I'll use this stuff, pretty much daily once we populate some of the funcs. I left a comment on the gateway piece but that can really come much later down the pipe.

iroh-ctl/src/main.rs Show resolved Hide resolved
iroh-ctl/src/p2p.rs Show resolved Hide resolved
iroh-ctl/src/gateway.rs Outdated Show resolved Hide resolved
@ramfox ramfox dismissed stale reviews from Arqu and dignifiedquire via 97a1990 June 23, 2022 22:04
dignifiedquire
dignifiedquire reviewed Jun 24, 2022
View reviewed changes
iroh-ctl/src/p2p.rs Outdated Show resolved Hide resolved
@ramfox ramfox mentioned this pull request Feb 17, 2023
Open
@dignifiedquire
Copy link
Contributor

ci is sad

@ramfox ramfox force-pushed the ctl branch 2 times, most recently from cf7c10f to 43976a8 Compare July 1, 2022 17:18
@ramfox ramfox merged commit c6bdca3 into n0-computer:main Jul 1, 2022
@ramfox ramfox deleted the ctl branch July 1, 2022 19:56
dignifiedquire pushed a commit that referenced this pull request Feb 20, 2023
@rklaehn
Merge pull request #123 from n0-computer/cid
1a127fa 
Add newtype wrapper for Hash that is compatible with Cid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

@Arqu Arqu Arqu left review comments

Assignees

@ramfox ramfox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

basic CLI for gateway, storage, and network processes irohctl talks to all processes
3 participants
@ramfox @dignifiedquire @Arqu