Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking pull request bodies #20

Merged
merged 3 commits into from
May 29, 2023
Merged

Conversation

jonathanio
Copy link
Contributor

Add the initial code to check the body of the pull request, which currently requires that it meets a minimum length once the body has been split (if the text to split on has been supplied).

Part of: #1

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

Expand on the interfaces used for Title and Labels checks to provide an
global-type interface which combines all the interface types created
and adds some additional functions needed as part of the preparation of
checks and automations.
Add the initial code to check the body of the  pull request,
which currently requires that it meets a minimum length once the body
has been split (if the text to split on has been supplied).
Move the defaults for the label-prefixes option into the pull-requester
code as these will be the defaults for the n3tuk organisation as a
whole.
@jonathanio jonathanio added priority/high This is a high-priority issue or pull reqest release/feature A new feature is added with this pull request type/enhancement Adding or requesting a new feature update/documentation Update with improvements to the documentation update/github-action Update with changes to the GitHub Action update/go Update with changes to Go files or applications labels May 29, 2023
@jonathanio jonathanio self-assigned this May 29, 2023
@jonathanio jonathanio requested a review from a team as a code owner May 29, 2023 08:35
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #20 (b6f78e2) into main (6002e12) will increase coverage by 4.58%.
The diff coverage is 46.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   41.61%   46.19%   +4.58%     
==========================================
  Files           4        5       +1     
  Lines         149      184      +35     
==========================================
+ Hits           62       85      +23     
- Misses         87       99      +12     
Impacted Files Coverage Δ
internal/action/main.go 0.00% <0.00%> (ø)
internal/github/main.go 0.00% <0.00%> (ø)
internal/action/check_description.go 100.00% <100.00%> (ø)

@jonathanio jonathanio merged commit 0dec776 into main May 29, 2023
@jonathanio jonathanio deleted the add-body-check branch May 29, 2023 08:39
@jonathanio jonathanio changed the title Add support for checking pull request bodies Add support for checking pull request bodies Jun 1, 2023
@jonathanio jonathanio linked an issue Jun 1, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high This is a high-priority issue or pull reqest release/feature A new feature is added with this pull request type/enhancement Adding or requesting a new feature update/documentation Update with improvements to the documentation update/github-action Update with changes to the GitHub Action update/go Update with changes to Go files or applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create standard GitHub Action for checking and automating pull request checks
1 participant