From bfa816541c915b4723202fb20376033323704b41 Mon Sep 17 00:00:00 2001 From: Mike Arvela Date: Tue, 13 Sep 2022 14:09:25 +0300 Subject: [PATCH 1/2] fix(cli): catch errors on updating workflow --- .../PublicApi/v1/handlers/workflows/workflows.handler.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts b/packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts index 0a41e1d478092..74aa2bd0aba3f 100644 --- a/packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts +++ b/packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts @@ -198,7 +198,13 @@ export = { await workflowRunner.remove(id.toString()); } - await updateWorkflow(sharedWorkflow.workflowId, updateData); + try { + await updateWorkflow(sharedWorkflow.workflowId, updateData); + } catch (error) { + if (error instanceof Error) { + return res.status(400).json({ message: error.message }); + } + } if (sharedWorkflow.workflow.active) { try { From cbda0e6235782ee2d315abaf457b439856960282 Mon Sep 17 00:00:00 2001 From: ricardo Date: Wed, 14 Sep 2022 11:09:59 -0400 Subject: [PATCH 2/2] :zap: Don\'t allow additionalProperties in the workflow schema --- .../PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml index bac8120af854d..f04070f85b5d7 100644 --- a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml +++ b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml @@ -1,4 +1,5 @@ type: object +additionalProperties: false required: - name - nodes