New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change artisan commands signature #668

Closed
mohammedmanssour opened this Issue Nov 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@mohammedmanssour
Copy link

mohammedmanssour commented Nov 19, 2018

Hi

I'm a big fan of this Laravel package and I use it in almost all of my clients project, but I'm not in favor of the current artisan commands signature module:make-something specially that Laravel has a different signature for its commands make:something.

so what do you think about chaning artisan signature? from module:make-someting to make:module:someting, this way - I think - it would be more comfortable and intuitive to use.

if you don't want to make a breaking change, we can build command aliases for the original commands

make:module:something is an alias for module:make-someting.

if you agree with this suggestion, then I'd more than happy to make a PR.

Thanks

@nWidart

This comment has been minimized.

Copy link
Owner

nWidart commented Nov 27, 2018

Hi,

I'm not sure what this would accomplish.
The current command naming pattern was not intended to look like the ones in laravel, and I don't see a proper reason to so.

@nWidart nWidart closed this Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment