Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the folder assets in resources #770

Closed
pmochine opened this issue May 31, 2019 · 4 comments

Comments

@pmochine
Copy link

commented May 31, 2019

Hey ho :)

Now could you remove the assets folder in resources, because since Laravel 5.8 we don't use it anymore.

Thanks, :D (p.S. I wanted to create a pull request, but just couldn't find the stub for it...)

@mikemand

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Hi,

It's done here:

'assets/js/app' => 'Resources/assets/js/app.js',
'assets/sass/app' => 'Resources/assets/sass/app.scss',

You can change this in your own config until someone PRs it.

@thompsonco

This comment has been minimized.

Copy link

commented Jun 2, 2019

@pmochine We still have the option to use the assets folder in 5.8. It's just a case of creating the assets folder and updating webpack.mix.js

Having an assets folder is much preferred in any case.

@pmochine

This comment has been minimized.

Copy link
Author

commented Jun 2, 2019

@pmochine We still have the option to use the assets folder in 5.8. It's just a case of creating the assets folder and updating webpack.mix.js

Having an assets folder is much preferred in any case.

Sorry, I should have written it better. I don't mean the folder /Assets/, but meant Resources/assets

@nWidart

This comment has been minimized.

Copy link
Owner

commented Sep 11, 2019

I'll close this as there hasn't been a reply in a while, feel free to comment if needed.

@nWidart nWidart closed this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.