Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Route serviceprovider #485
In Laravel 5.3 there was a change in how routes were loaded (see: https://laravel.com/docs/5.3/upgrade#upgrade-5.3.0)
However when using this package I'd always find myself re-writing the routes in the modules to reflect the same changes as in the framework.
Thus I decided to create a PR reflecting the changes from the framework.
Updated the tests to reflect the new changes. Now all tests success on my and but because I don't know the ins and outs of the module I might have forgotten something. If so, please let me know so I can fix this.
Now this is all on the basis this is a change you are willing to add to the package of course :)
Thanks for the contribution! Those route changes are optional, however. Where routes are defined is not imposed by the framework.
On top of this, laravel 5.3 is not supported anymore.
In the future try create an issue first in order to discuss changes, and not wasting time on your end.
@bloggervista I never stated anything was wrong with the code as it is now. I just felt an update on how routes are defined could be updated. Laravel didn't make the change themselves for nothing.
My opinion was if someone starts a new Laravel project from scratch and then use this module, the way routes are defined would be the same as Laravel allowing them to follow the Laravel docs to continue onwards.
Seeing @nWidart you haven't rejected the PR yet, are you considering this change or should I create and Issue asking people if this is a change they'd like to see?
If you don't plan on accepting the PR, just decline it and don't leave me hanging here.
ps. It would seem referring back to L5.3 only caused more confusion than support for this change :/
yes i know what you mean.
I also think better to place routes inside routes folder instead of http because i think routes is the first place everybody goes . I guess that was the reason laravel moved routes from app/http/routes to routes/web .
I guess this pr is good :)