Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Register Factories when Running in Console #773

Merged
merged 4 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@nmfzone
Copy link
Contributor

commented Jun 12, 2019

I think this approach can reduce the application to load the unused file when running in browser.

nmfzone added some commits Jun 12, 2019

Only Register Factories when Running in Console
I think this approach can reduce the application to load the unused file when running in browser.
Use runningInConsole from app
Since this package not support Laravel 5.1, we just can use `runningInConsole` directly from app.
@nWidart

This comment has been minimized.

Copy link
Owner

commented Jun 12, 2019

Thanks, good idea! 👌

@nmfzone

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Sure 👌
But, I'm not sure why Travis CI fails. I think you should update the tests snapshot.

@nWidart

This comment has been minimized.

Copy link
Owner

commented Jun 13, 2019

Indeed, that's something you need to run on your end.

@nmfzone

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@nWidart Ohh, I see..on my way.

@nWidart nWidart merged commit 2a5a1bd into nWidart:master Jun 13, 2019

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nWidart

This comment has been minimized.

Copy link
Owner

commented Jun 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.