Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404s to requirements/setup in README.md #283

Merged
merged 2 commits into from Oct 2, 2018
Merged

Conversation

tripph
Copy link
Contributor

@tripph tripph commented Oct 1, 2018

It looks like the documentation structure had changed without the README being updated. Both links should now go to the correct page.

@nabeelio
Copy link
Owner

nabeelio commented Oct 2, 2018

Hi, thanks for the fix - can you please fix the PR so it's merging into the dev branch, not master? Thanks!

@nabeelio nabeelio self-requested a review October 2, 2018 14:34
@tripph tripph changed the base branch from master to dev October 2, 2018 18:18
@tripph
Copy link
Contributor Author

tripph commented Oct 2, 2018

Hi, thanks for the fix - can you please fix the PR so it's merging into the dev branch, not master? Thanks!

Absolutely, my bad. It should be updated and pointing at dev now.

@nabeelio
Copy link
Owner

nabeelio commented Oct 2, 2018

I don't know why the build is failing 🤷‍♂️ I'll just merge it anyway. Thanks!

@nabeelio nabeelio merged commit 270556e into nabeelio:dev Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants