Add repositories (packages.json) management using S3

[JJK801]

Hi,

This sample of code implements possibility of fetch repositories packages.json using s3:// scheme.

Need to wait composer/composer#2434 to be merged.

Thanks,

Jérémy

[JJK801]

composer's PR has been merged, if you're ok, you can merge this one

[omansour]

👍

[JJK801]

ping @naderman

Please, we really need this feature :)

Thanks

[naderman]

So since the composer PR was reverted this won't work. Are you working on a new composer PR?

[JJK801]

It was remerged by Seldaek just after with his own fix on VcsRepository.

[naderman]

Oh I saw your fix being closed and didn't have a chance to ask him yet :D

[naderman]

Alright this generally looks good then, but I'd prefer if you could merge the getContents and download methods now since the code is mostly duplicated. Could you do that? Cheers!

[JJK801]

no problem

[JJK801]

Is it what you expected @naderman ?

[naderman]

Yes, but there is a problem now. It still has to use the guzzle mechanism with fopen for writing because that streams the content. But the way you wrote it with file_put_contents now it loads the entire file into RAM which can be an issue with big downloads.

[JJK801]

You're right, must be much better now

[naderman]

Ok cool, this looks good. Thanks for the patience and good work :)

[naderman]

Also tagged a new version 0.2.4

[JJK801]

Thanks!

[omansour]

Excellent :)

Thanks to you both

Le 16 déc. 2013 à 17:25, Nils Adermann notifications@github.com a écrit :

Also tagged a new version 0.2.4

—
Reply to this email directly or view it on GitHub.