Questions about channel identity LBP loss

[kice]

waifu2x/lib/LBPCriterion.lua

Lines 12 to 18 in 3613450

	if i == 1 then
	-- channel identity
	for j = 1, ch do
	filter.weight[i]:fill(0)
	filter.weight[i][i][math.floor(k/2)+1][math.floor(k/2)+1] = 1
	end
	end

I think you want to create an identity for input channels (pixelwise loss), but this section only make identity for the first channel.

if i == 1 then
    -- identity for input channels of first layer
    for j = 1, ch do
        filter.weight[j]:fill(0)
        filter.weight[j][j][math.floor(k/2)+1][math.floor(k/2)+1] = 1
    end
end

where filter.weight[i] change into filter.weight[j], use j instad of i, which always is 1 after the if conditation.

[nagadomi]

You are right. This is an embarrassing bug. Thank you for the report. Fixed.
However, I think there is almost no difference in practice.