Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country India #75

Closed
prasadtelkikar opened this issue Apr 8, 2018 · 9 comments
Closed

Add country India #75

prasadtelkikar opened this issue Apr 8, 2018 · 9 comments
Assignees

Comments

@prasadtelkikar
Copy link
Contributor

Need to implement provider for Indian holidays
India is know for Unity in diversity. you can see diversity in holidays as well. Wikipedia suggests more than 20 days as holidays based on religions, states etc. Wikipedia: Public holidays in India.

Following are the national holidays which we need to add in IndianProvider.cs. Reference: Indian post office holiday list.

I categorized list into two sections.

  1. Holidays with fixed date.
  2. Holidays which varies in date.

Holidays with fixed date. All dates are in dd/MM/yyyy format

  • Republic day of India. -> 26/01/2018
  • Independence day of India -> 15/08/2018
  • Mahatma Gandhi birthday -> 02/10/2018
  • Christmas -> 25/12/2018

Holidays which varies in date. All dates are in dd/MM/yyyy format

All holidays which are categorized into second section may vary depends upon user.
Holidays in second categories needs some sort of algorithm to get exact date.

@prasadtelkikar
Copy link
Contributor Author

I stared working on Indian provider, added all fixed holidays. Need to work on second section holidays.

@tinohager
Copy link
Member

Okay thanks. I think this page is also a good reference but it's no list available, of the full year. https://www.india.gov.in/calendar?date=2018

@tinohager tinohager self-assigned this Apr 8, 2018
@iamrishav
Copy link

@tinohager are you working on this issue??

@tinohager
Copy link
Member

@iamrishav I don't have time for this at the moment.

@prasadtelkikar
Copy link
Contributor Author

@tinohager , @iamrishav I can work on this enhancement, but it seems pretty difficult. because dates which comes under the second category are more than first category. (Refer my first message for categories).
We do not have any logic or algorithm to implement dates from second category.

If any one of you help me to design/develop logic for holiday dates which varies every year then It would be really helpful

MaximeGenevier added a commit to MaximeGenevier/Nager.Date that referenced this issue Jan 6, 2022
@tinohager
Copy link
Member

@MaximeGenevier Are you still creating a pull request for the new India provider?

@MaximeGenevier
Copy link
Contributor

@MaximeGenevier Are you still creating a pull request for the new India provider?

@tinohager No sorry, I didn't had time to work on it anymore

@tinohager
Copy link
Member

@MaximeGenevier Thanks for the fast feedback

@tinohager
Copy link
Member

@iamrishav @prasadtelkikar Would any of you like to complete the work of MaximeGenevier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants