Message::Headers.init_response change breaks WebMock #107

Closed
Odaeus opened this Issue Aug 14, 2012 · 4 comments

Comments

Projects
None yet
2 participants

Odaeus commented Aug 14, 2012

Hi,

Can you please confirm if the Message::Headers.init_response method is part of the public API or private?

The latest point release (2.2.6) has caused WebMock to break as it only expects to supply one parameter: https://github.com/bblimke/webmock/blob/master/lib/webmock/http_lib_adapters/httpclient_adapter.rb#L99

If you consider this private then I guess WebMock should be updated but if it's public it shouldn't have changed in a point release.

Thanks,
Andrew

Owner

nahi commented Aug 14, 2012

Oops, I should have added the second argument as an optional one. I'll push 2.2.7 soon.

Thanks for letting me know this!

@nahi nahi added a commit that referenced this issue Aug 14, 2012

@nahi nahi Fix arity incompatibility introduced in 2.2.6
ed9c65c for #97 required
(Header|Body)init_response argument is given. It broke Webmock
compatibility.  See #107.
36068aa

Odaeus commented Aug 14, 2012

Cool, thanks for the quick fix! Will update and test when I can.

Owner

nahi commented Aug 14, 2012

Thanks in advance. I'll close this after your confirmation.

Odaeus commented Aug 14, 2012

Works for me, awesome, thanks!

Odaeus closed this Aug 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment