Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebird Events #92

Merged

Conversation

@arteev
Copy link
Contributor

arteev commented Oct 6, 2019

Greetings @nakagami !
I implemented the Firebird Event. This issue (#34) was opened by me three years ago, but no one has done this task.
If it’s not difficult for you, then please do a review and, if possible, accept pull request.
I’m also ready to listen to criticism, and your suggestions for improvement.
I understand that the implemented option is foreign to database/sql, but at the moment the database/sql package does not conceptually assume an event model.
Thank!

@arteev

This comment has been minimized.

Copy link
Contributor Author

arteev commented Oct 6, 2019

I see, there is a problem with tests in CI, I will fix it

@nakagami

This comment has been minimized.

Copy link
Owner

nakagami commented Oct 6, 2019

Thanks !
It seems good.
I hope someone will use this feature.
 

@nakagami nakagami merged commit bba3f54 into nakagami:master Oct 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.