Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong logic for handling large BLOBs? #58

Closed
movermeyer opened this issue Jun 1, 2015 · 1 comment
Closed

Wrong logic for handling large BLOBs? #58

movermeyer opened this issue Jun 1, 2015 · 1 comment

Comments

@movermeyer
Copy link
Contributor

@movermeyer movermeyer commented Jun 1, 2015

Shouldn't line 204 of fbcore.py be

while n != 2:

instead of

while n == 1:

I'm finding that the protocol will return a 0 instead of a 1 every 507873 bytes (strange number).
As a result of this logic, my BLOB is being truncated.

I haven't been able to prove that 0 is an OK response as I can't find the spec and reading the C++ code isn't my strong suit. But changing the Python to 'n != 2' seems to work.

Your input would help a lot.

P.S: I noticed that the same logic is also found in your Go version
I've filed a similar issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants